Skip to content

Remove Gas estimator link in footer #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

Remove Gas estimator link in footer #5134

merged 1 commit into from
Oct 22, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 22, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on modifying the app-footer.tsx component by removing a link related to the "Gas Estimator".

Detailed summary

  • Removed the Link component for "Gas Estimator" that had:
    • className set to "px-[10px] py-[6px] text-muted-foreground text-sm hover:underline"
    • href pointing to "https://thirdweb.com/gas"
    • target set to "_blank"

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cdb907f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 11:53pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 22, 2024 11:53pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 22, 2024 11:53pm
wallet-ui ⬜️ Skipped (Inspect) Oct 22, 2024 11:53pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 23:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 23:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 23:40 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 22, 2024 23:40
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 22, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (364d97e) to head (cdb907f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5134   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1060     1060           
  Lines       54874    54874           
  Branches     3957     3957           
=======================================
  Hits        24862    24862           
  Misses      29320    29320           
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 364d97e
packages 40.26% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 501 ms (+66.25% 🔺) 1.4 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 873 ms (-10.83% 🔽) 3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 151 ms (+41.17% 🔺) 248 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 82 ms (+301.94% 🔺) 92 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 144 ms (-10.5% 🔽) 492 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024 •
edited
Loading

Merge activity

@MananTank
Remove Gas estimator link in footer (#5134)
cdb907f 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on modifying the `app-footer.tsx` component by removing the `Gas Estimator` link from the footer.

### Detailed summary
- Removed the `Link` component for `Gas Estimator`.
- The remaining `Link` component for `chainlist` retains its class names and attributes.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-23-remove_gas_estimator_link_in_footer branch from d6f114f to cdb907f Compare October 22, 2024 23:51
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 23:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 23:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 23:51 Inactive
@graphite-app graphite-app bot merged commit cdb907f into main Oct 22, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-23-remove_gas_estimator_link_in_footer branch October 22, 2024 23:54
@vercel vercel bot temporarily deployed to Production – wallet-ui October 22, 2024 23:54 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 22, 2024 23:54 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 22, 2024 23:54 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls